-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cell table batching functionality #726
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…rate_cell_table is tested on different-sized FOVs
@benoberlton this PR should address the error caused by variable image sizes you were getting during |
@ngreenwald realized I needed to update the documentation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh that's strange, I didn't know review status could block subsequent changes. Won't have time to look tonight, I'll submit this which will hopefully address the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to add back in the code that was removed. Seems like this has happened a bunch of times on your PRs, I think you said your editor does it automatically?
@ngreenwald yeah, looks like I'll need to officially need to retire my merge tool lol, Sublime Merge hasn't been the easiest to interface with. |
… unbatch_cell_table
…-analysis into unbatch_cell_table
@ngreenwald this should resolve |
What is the purpose of this PR?
Addresses stage 1 of #720, removing batching of
generate_cell_table
.How did you implement your changes
The batch loop inside
generate_cell_table
has been changed to a per-FOV iteration.The call in
1_Segment_Image_Data.ipynb
needed to be updated accordingly.Remaining issues
In particular, changes were made to the way
fovs
andfilenames
were being handled ingenerate_cell_table
. MIBItiff support requires us to retrievefilenames
, however for non-MIBItiffs the loop needs to be more fully guarded againstfilenames
being set toNone
(which happens when you calllist_files
on a folder structure).We will not have to worry about this once MIBItiff support gets phased out.