Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename notebooks folder to templates #729

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Rename notebooks folder to templates #729

merged 4 commits into from
Oct 3, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #725. It's no longer necessary to suffix the templates folder with _ark; this is a remnant of when the toffy pipeline was here.

How did you implement your changes

Change any reference to templates_ark to templates.

@alex-l-kong alex-l-kong self-assigned this Sep 27, 2022
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you use an editor/github search to make sure you got all the old template_ark references? And did you try it out yourself with the new docker script to make sure it all works?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong
Copy link
Contributor Author

alex-l-kong commented Sep 29, 2022

@ngreenwald good catch, looks like Github search isn't reliable for Jupyter notebooks. Just one minor reference fix.

start_docker.sh works as expected, including with the -u flag.

@ngreenwald
Copy link
Member

Sounds good. Going to wait to merge this in until we're ready for a new release to make sure people aren't stuck with an intermediate version

@ngreenwald ngreenwald merged commit 367e133 into main Oct 3, 2022
@ngreenwald ngreenwald deleted the templates_rename branch October 3, 2022 19:00
@srivarra srivarra added the enhancement New feature or request label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename templates_ark to templates
3 participants