Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make non-parallel loops canon for Pixie #779

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Make non-parallel loops canon for Pixie #779

merged 9 commits into from
Oct 20, 2022

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #771. Adds option to run a non-parallel version of Pixie preprocessing, SOM and meta cluster assignment, and meta cluster renaming.

How did you implement your changes

Add control flow statements handled by a dedicated multiprocess argument.

@alex-l-kong alex-l-kong self-assigned this Oct 19, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ngreenwald
ngreenwald requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will you run the pixel clustering notebook with and without multiprocessing to make sure nothing slipped through? The python code is all tested, but the R code isn't

@alex-l-kong
Copy link
Contributor Author

alex-l-kong commented Oct 19, 2022 •
edited
Loading

Looks good. Will you run the pixel clustering notebook with and without multiprocessing to make sure nothing slipped through? The python code is all tested, but the R code isn't

Already tested.

ngreenwald
ngreenwald approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ngreenwald ngreenwald merged commit 6073dbe into main Oct 20, 2022
@ngreenwald ngreenwald deleted the add_single_proc branch October 20, 2022 05:38
@srivarra srivarra added the enhancement New feature or request label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngreenwald ngreenwald ngreenwald approved these changes

Assignees

@alex-l-kong alex-l-kong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove parallel processing from pixie
3 participants
@alex-l-kong @ngreenwald @srivarra