Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged Installation Instructions #840

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Tagged Installation Instructions #840

merged 3 commits into from
Nov 23, 2022

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #830.

How did you implement your changes

Added directions to install a specific release of Ark.

Remaining issues

N/A.

@srivarra srivarra added the documentation Adding documentation to areas of the codebase. label Nov 22, 2022
@srivarra srivarra self-assigned this Nov 22, 2022
@srivarra srivarra marked this pull request as ready for review November 22, 2022 18:16
@srivarra srivarra requested a review from ngreenwald November 22, 2022 18:23
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will you also update the developer docs for making a new release


```
git clone https://github.com/angelolab/ark-analysis.git
git clone https://github.com/angelolab/ark-analysis.git --depth 1 --branch v0.4.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try it out to make sure this works as expected, i.e. previous docker gets pulled and specified from start_docker.sh script, etc etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the VERSION in start_docker_sh is v0.4.4, so it runs as expected.

@srivarra srivarra changed the title Tagged Installatin Instructions Tagged Installation Instructions Nov 22, 2022
@srivarra srivarra requested a review from ngreenwald November 22, 2022 22:03
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ngreenwald ngreenwald merged commit 857f692 into main Nov 23, 2022
@ngreenwald ngreenwald deleted the git_install_instructions branch November 23, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding documentation to areas of the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme instructions for git installation with current tag
2 participants