Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Utils - Expanding Acceptable File Types #878

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #866. Users will now be able to read in files ending in "tif" (one 'f').

How did you implement your changes

Used the EXTENSION_TYPES constant to generalize over all major image formats ("tif", "tiff", "png", etc...)

Remaining issues

N/A.

@srivarra srivarra added the enhancement New feature or request label Jan 10, 2023
@srivarra srivarra self-assigned this Jan 10, 2023
@srivarra srivarra marked this pull request as ready for review January 10, 2023 19:25
@srivarra srivarra requested review from ngreenwald and cliu72 January 10, 2023 19:25
Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@srivarra srivarra merged commit 83768c8 into main Jan 10, 2023
@srivarra srivarra deleted the load_utils/load_tif branch January 10, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have load_imgs_from_tree also look for .tif files
2 participants