Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark Refactor #935

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Ark Refactor #935

merged 8 commits into from
Feb 23, 2023

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Feb 21, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Addresses part of #901. Fixed the runner running out of space.

How did you implement your changes

  • Moved utils.synthetic_spatial_datagen to tests/
  • Moved utils.spatial_analysis_utils to src/ark/analysis/
  • Moved utils.segmentation_utils to src/ark/segmentation/

After each notebook's tests are finished, the data is cleared.

Remaining issues

N/A

@srivarra srivarra self-assigned this Feb 21, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@srivarra srivarra marked this pull request as ready for review February 22, 2023 22:24
@srivarra srivarra requested a review from ngreenwald February 22, 2023 22:24
@srivarra srivarra added the enhancement New feature or request label Feb 22, 2023
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor syntax

tests/utils/notebooks_test.py Outdated Show resolved Hide resolved
tests/utils/deepcell_service_utils_test.py Outdated Show resolved Hide resolved
@srivarra srivarra requested a review from ngreenwald February 23, 2023 00:44
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Testing out the merge queue again

@ngreenwald ngreenwald added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit d7e7106 Feb 23, 2023
@ngreenwald ngreenwald deleted the refactor/ark branch February 23, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants