Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ezSegmentation #958

Merged
merged 123 commits into from
Nov 29, 2023
Merged

ezSegmentation #958

merged 123 commits into from
Nov 29, 2023

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Adds ezSegmentation functionality. This PR will add many of the backend features.
The notebook and interactive Jupyter components will come in a separate PR.

How did you implement your changes

Currently added the following files:

  • ez_object_segmentation
  • ez_object_segmentation_test

Remaining issues

Need to add the rest of the stuff in #847, #907.

@srivarra srivarra added the enhancement New feature or request label Mar 23, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong
Copy link
Contributor

@srivarra looks like the tests for ez_object_segmentation.py are still failing. Can you look into this?

Copy link
Contributor Author

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good, just one odd line which seems to work.

src/ark/segmentation/marker_quantification.py Outdated Show resolved Hide resolved
@alex-l-kong alex-l-kong added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 99a9abb Nov 29, 2023
17 of 18 checks passed
@alex-l-kong alex-l-kong deleted the ezSegmenter/start branch November 29, 2023 21:18
@srivarra srivarra linked an issue Nov 30, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ezSegmenter
3 participants