Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Kmeans parameter to prior default #977

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Set Kmeans parameter to prior default #977

merged 2 commits into from
Apr 24, 2023

Conversation

camisowers
Copy link
Contributor

@camisowers camisowers commented Apr 24, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Maybe fixes #968.

How did you implement your changes

Changes n_init from 'auto' to 10, to keep the algorithm params consistent with the prior default value.

Note: I've pinned alpineer temporarily so that the new multiple tiled stitching adjustments made won't apply until a formal PR is opened. A few of the ark stitching functions will need to be tweaked.

Remaining issues

Unrelated to #967. I'm still not quite sure what's going on there.

@camisowers camisowers added the bug Something isn't working label Apr 24, 2023
@camisowers camisowers self-assigned this Apr 24, 2023
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the description to avoid closing it until we've tested it to confirm.

I agree about pinning alpineer, the goal of having things in different repos is that nothing will update until we want it to.

@ngreenwald ngreenwald merged commit 675a7e1 into main Apr 24, 2023
@ngreenwald ngreenwald deleted the kmeans_validation branch April 24, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential bug in neighborhood assignments
2 participants