Prevent duplicate renamed metaclusters in Pixie remapping #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
srivarra
requested changes
May 25, 2023
camisowers
reviewed
May 25, 2023
cliu72
reviewed
Jun 2, 2023
cliu72
reviewed
Jun 2, 2023
cliu72
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #972. Duplicate metacluster renamed values causes issues with grouping in later steps, so this should not be allowed.
How did you implement your changes
Verify that the provided renamed metacluster has not already been taken. If it has, then terminate the renaming process. This will cause that particular metacluster name to be truncated for the time being and is noted in the documentation.