Add extensive documentation to the maldi-pipeline.ipynb notebook
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Pull Request Test Coverage Report for Build 12381828443Details
💛 - Coveralls |
goterm
reviewed
Dec 16, 2024
| @@ -4,14 +4,22 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@goterm just pushed new changes, do they address this?
goterm
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
In anticipation of the presentation next week, the current MALDI extraction notebook is not formatted nor documented well. These notebooks need to be brought up to angelolab standards.
How did you implement your changes
Remaining issues
Certain portions have been intentionally marked as WIP.