Changed enum code to allow simple value types, and a rawValue constructor #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I completely missed this one! I thing I have noticed is that the computed properties and methods inside the enum are not been converted anymore but just removed. The previous tests were not covering that. I am going to add some tests with that and the new cases before merging |
|
OK, I think it is now solved. Methods and properties weren't properly converted before, but the code conversion was working just as a result of calling super and letting the standard swift conversion take over. Now it should be OK. Thanks for the huge PR! |
angelolloqui
approved these changes
May 3, 2019
This was referenced May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early pull request to get feedback before making tests.