Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set parameters for blueprint generation. See angelozerr/angular2-eclipse#41 #42

Merged
merged 4 commits into from
Feb 12, 2017

Conversation

probert94
Copy link
Contributor

I added the possibility to set the different parameters when generating a new Angular Element/Blueprint using the Wizards.
Following Paramters are supported:
Class:

  • --spec

Component:

  • --flat
  • --inline-template
  • --inline-style
  • --prefix
  • --spec
  • --view-encapsulation
  • --change-detection
  • --skip-import
  • --export

Directive:

  • --flat
  • --prefix
  • --spec
  • --skip-import
  • --export

Module:

  • --spec
  • --routing

Pipe:

  • --flat
  • --spec
  • --skip-import
  • --export

Service:

  • --flat
  • --spec

The "--module" parameter is still missing (see #34 )

@probert94
Copy link
Contributor Author

I changed the "skip npm" parameter to "skip install", to support latest angular-cli version.

@angelozerr angelozerr merged commit fd13809 into angelozerr:master Feb 12, 2017
@angelozerr
Copy link
Owner

Great job @Springrbua ! Many thanks!

@angelozerr angelozerr added this to the 1.2.0 milestone Feb 12, 2017
@angelozerr
Copy link
Owner

angelozerr commented Feb 12, 2017

@Springrbua perhaps we should add parameter name in the label like Generate spec file (--spec)

What do you think?

@probert94
Copy link
Contributor Author

You are right we should add that. I'll take a look at it, maybe I need to rearramge the params.

@angelozerr
Copy link
Owner

And perhaps add a better description for each param (same than ng help) with a tooltip?

@probert94
Copy link
Contributor Author

Unfortunately "ng help" does only show the parameters, their default value and the aliases:

      class <name> <options...>
        --spec (Boolean)
          aliases: -spec

The docs seem to have at least a little description of the parameters, we could add that.

@angelozerr
Copy link
Owner

we could add that.

Yes!

@probert94
Copy link
Contributor Author

We could also add the parameter name ("--spec" for example) inside the tooltip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants