Merge pull request #459 from angrykoala/dev

2.13.0
angrykoala · Jul 24, 2020 · 95bc607 · 95bc607
2 parents a9334b0 + baa28cf
commit 95bc607
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 53 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,6 @@
 language: node_js
 os:
     - linux
-    - windows
 node_js:
     - "lts/*"
 sudo: false

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+2.13.0 / 2020-07-24
+===================
+
+* Puppeteer updated to 5.0
+* Dependencies updated
+* Fixed parameters signature for textContains and not.textContains assertions
+* Removed publish release action
+
 2.12.1 / 2020-07-06
 ===================
 

diff --git a/lib/browser/assertions/assertions_core.ts b/lib/browser/assertions/assertions_core.ts
@@ -80,7 +80,7 @@ export default class AssertionsCore {
         }
     }
 
-    public async textContains(selector: WendigoSelector, expected: string, msg?: string): Promise<void> {
+    public async textContains(selector: WendigoSelector, expected: string | Array<string>, msg?: string): Promise<void> {
         if ((!expected && expected !== "") || (Array.isArray(expected) && expected.length === 0)) {
             throw new WendigoError("assert.textContains", `Missing expected text for assertion.`);
         }

diff --git a/lib/browser/assertions/browser_not_assertions.ts b/lib/browser/assertions/browser_not_assertions.ts
@@ -51,7 +51,7 @@ export default class BrowserNotAssertions {
         }
     }
 
-    public async textContains(selector: WendigoSelector, expected: string, msg?: string): Promise<void> {
+    public async textContains(selector: WendigoSelector, expected: string | Array<string>, msg?: string): Promise<void> {
         if ((!expected && expected !== "") || (Array.isArray(expected) && expected.length === 0)) {
             throw new WendigoError("assert.not.textContains", `Missing expected text for assertion.`);
         }

diff --git a/lib/browser/browser_core.ts b/lib/browser/browser_core.ts
@@ -108,11 +108,11 @@ export default abstract class BrowserCore {
 
     @OverrideError()
     public async openFile(filepath: string, options: OpenSettings): Promise<void> {
-        const absolutePath = path.resolve(filepath);
         try {
+            const absolutePath = path.resolve(filepath);
             await this.open(`file://${absolutePath}`, options);
         } catch (err) {
-            return Promise.reject(new FatalError("openFile", `Failed to open "${filepath}". File not found.`));
+            throw new FatalError("openFile", `Failed to open "${filepath}". File not found.`);
         }
     }
 

diff --git a/lib/puppeteer_wrapper/puppeteer_page.ts b/lib/puppeteer_wrapper/puppeteer_page.ts
@@ -49,11 +49,11 @@ export default class PuppeteerPage {
         return this.page.setViewport(finalConfig);
     }
 
-    public on<K extends keyof PageEventObj>(eventName: K, cb: (msg: PageEventObj[K]) => Promise<void>): void {
+    public on<K extends keyof PageEventObj>(eventName: K, cb: (msg: PageEventObj[K]) => void): void {
         this.page.on(eventName, cb);
     }
 
-    public off<K extends keyof PageEventObj>(eventName: K, cb: (msg: PageEventObj[K]) => Promise<void>): void {
+    public off<K extends keyof PageEventObj>(eventName: K, cb: (msg: PageEventObj[K]) => void): void {
         this.page.off(eventName, cb);
     }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wendigo",
-  "version": "2.12.1",
+  "version": "2.13.0",
   "description": "A proper monster for front-end automated testing",
   "engines": {
     "node": ">=8.0.0"
@@ -43,19 +43,19 @@
   "dependencies": {
     "compositer": "^1.3.6",
     "is-class": "0.0.9",
-    "puppeteer": "~3.3.0"
+    "puppeteer": "~5.2.1"
   },
   "devDependencies": {
-    "@types/mocha": "^7.0.2",
-    "@types/node": "^14.0.11",
-    "@types/puppeteer": "~3.0.0",
+    "@types/mocha": "^8.0.0",
+    "@types/node": "^14.0.25",
+    "@types/puppeteer": "~3.0.1",
     "basic-auth": "^2.0.1",
-    "eslint": "^7.2.0",
+    "eslint": "^7.5.0",
     "express": "^4.17.1",
-    "markdownlint-cli": "^0.23.1",
-    "mocha": "^7.2.0",
+    "markdownlint-cli": "^0.23.2",
+    "mocha": "^8.0.1",
     "sinon": "^9.0.2",
     "tslint": "^6.1.2",
-    "typescript": "^3.9.5"
+    "typescript": "^3.9.7"
   }
 }