Merge pull request #117 from ftischler/main

fix typo in readme and adjust typing of shareAll
angular-architects · Feb 13, 2022 · 5ba3753 · 5ba3753
2 parents 2f95ce9 + 8208483
commit 5ba3753
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libs/mf/README.md b/libs/mf/README.md
@@ -271,7 +271,7 @@ shared: share({
         strictVersion: true,
         requiredVersion: 'auto',
         includeSecondaries: {
-            skip: ['@angular/http/testing']
+            skip: ['@angular/common/http/testing']
         }
     },
     [...]

diff --git a/libs/mf/src/utils/share-utils.ts b/libs/mf/src/utils/share-utils.ts
@@ -101,7 +101,7 @@ function addSecondaries(secondaries: string[], result: Config, shareObject: Conf
     }
 }
 
-export function shareAll(config: Config = {}, skip: string[] = [], packageJsonPath = ''): void {
+export function shareAll(config: Config = {}, skip: string[] = [], packageJsonPath = ''): Config {
 
     if (!packageJsonPath) {
         const stack = callsite();