Skip to content

Commit

Permalink
Merge pull request #147 from LoaderB0T/main
Browse files Browse the repository at this point in the history
Use "number" for port parameter during init
  • Loading branch information
manfredsteyer authored Mar 12, 2022
2 parents ee6ffe9 + 8d13356 commit cc6fee9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions libs/mf/src/schematics/mf/schema.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export interface MfSchematicSchema {
project: string;
port: string;
nxBuilders: boolean | undefined
port: number;
nxBuilders: boolean | undefined;
}
2 changes: 1 addition & 1 deletion libs/mf/src/schematics/mf/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"x-prompt": "Project name (press enter for default project)"
},
"port": {
"type": "string",
"type": "number",
"description": "The port to use for the federated module (remote, micro frontend, etc.)",
"x-prompt": "Port to use",
"$default": {
Expand Down
2 changes: 1 addition & 1 deletion libs/mf/src/schematics/mf/schematic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export default function config (options: MfSchematicSchema): Rule {

const configPath = path.join(projectRoot, 'webpack.config.js').replace(/\\/g, '/');
const configProdPath = path.join(projectRoot, 'webpack.prod.config.js').replace(/\\/g, '/');
const port = parseInt(options.port);
const port = options.port;
const main = projectConfig.architect.build.options.main;

const relWorkspaceRoot = path.relative(projectRoot, '');
Expand Down

0 comments on commit cc6fee9

Please sign in to comment.