remove dependency on word-wrap (fix for: CVE-2023-26115) #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the word-wrap library is severely out of date and seems mostly abandoned. And `npm audit` marks it as vulnerable to DoS. I think this should replace the dependency all together.
|
Here is a link to the CVE: https://www.cve.org/CVERecord?id=CVE-2023-26115 |
chris-kruining
changed the title
manfredsteyer
force-pushed
the
main
branch
4 times, most recently
from
12b4330
to
6ae2fa8
Compare
|
@chris-kruining any update on this fix? |
fixed the merge conflict, no further updates, it's ready AFAICT |
|
@aaburov can we merge or close this? would be a shame if it'll take another 3 months and then I'll just be out of date again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the word-wrap library is severely out of date and seems mostly abandoned. And
npm auditmarks it as vulnerable to DoS. I think this should replace the dependency all together.p.s. could you please also make a 14.x.x tag if/when this gets merged. we are in de middle of migrating from angular 13 to 14, and I've ran into this issue because of that