test(dataService): add basic tests for withDataService
#89
Conversation
|
Good idea @michael-small, I'll wait for the removal of the draft status. |
|
I am marking this as ready since it is basically done and covers most scenarios.
Perhaps this is too undercooked a submission as well but I think I may have overthought/overdone certain aspects and would appreciate feedback before going further in a fruitless direction. |
| TestBed.runInInjectionContext(() => { | ||
| const store = new Store(); | ||
|
|
||
| tick(1); |
There was a problem hiding this comment.
tick() should be sufficient. That applies to all your tests.
| updateAll(entity: Flight[]): Promise<Flight[]> { | ||
| return firstValueFrom( | ||
| of([ | ||
| { |
There was a problem hiding this comment.
I'd create a factory function which generates you a flight. That function should use by a default an default flight object and increments the id automatically with every call.
Its signature could be createFlight(flight: Partial<Flight>): Flight. As you see, you then only need to provide those values of Flight which differ from the default one.
There was a problem hiding this comment.
That should slim down all these mocking helpers, good idea.
Sounds good, thanks. I'll slim it down with your suggestions and a couple things that have occurred to me since and then @ you when it's at that point. |
PR comment: "tick() should be sufficient. That applies to all your tests." Change: Most uses of `tick(...)` were replaced, but ones that were time-sensitive to the mocks for loading time were retained
PR comment: I'd create a factory function which generates you a flight. That function should use by a default an default flight object and increments the id automatically with every call. Its signature could be createFlight(flight: Partial<Flight>): Flight. As you see, you then only need to provide those values of Flight which differ from the default one. Change: Made same function.
|
A) I slimmed the test down from 857 lines to 561 lines, ~33%, with your factory function suggestion. B) I also remembered these two TODO I keep fumbling with mocking out forced errors and testing that. Any tips / snippets? That lack of the error case tests aside, I think this PR is ready if you are fine with the outstanding size of the test suite. |
Prerequisite to feat: add support for observables to withDataService
I said that I would make tests for
withDataServicefeaturing support for observables. However, it would be good to have existing tests for the feature as it is currently with promises before thewithDataServiceis further extended.Once I have a test for each method of the
interface DataServicewith promises stubbed out then I'll bump this from a draft to a full PR. Tests are not my strong suit, so please roast these.edit:
Progress/TODO 9/29/2024