Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing user get's response unauthorized instead of not found #438

Closed
gintsgints opened this issue Aug 11, 2014 · 1 comment · Fixed by #453
Closed

Missing user get's response unauthorized instead of not found #438

gintsgints opened this issue Aug 11, 2014 · 1 comment · Fixed by #453
Labels
bug

Comments

@gintsgints
Copy link
Contributor

When authorized user do:

GET api/users/<user_id/

with user that does not exists it get's 401 - unauthorized.
Wouldn't be correct to respond with 404 - Not found ?
@balthazar
Copy link
Contributor

Yeah you're right, typo I think

@JaKXz JaKXz added the bug label Aug 11, 2014
@JaKXz JaKXz changed the title Authorised user get's response unauthorized. Missing user get's response unauthorized instead of not found Aug 11, 2014
kingcody added a commit to kingcody/generator-angular-fullstack that referenced this issue Aug 16, 2014
@kingcody
fix(app:api:user): Missing user response code
c176660 
Changes:
- Send `404` response code when a user cannot be found

Closes angular-fullstack#438
@kingcody kingcody mentioned this issue Aug 16, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(app:api:user): Missing user response code kingcody/generator-angular-fullstack
3 participants
@gintsgints @JaKXz @balthazar