This repository has been archived by the owner on Nov 30, 2018. It is now read-only.
Markers doRebuildAll=false still rebuilds all markers #1485
Comments
rcino
added a commit
to rcino/angular-google-maps
that referenced
this issue
Apr 7, 2016
Change model-key to use lodash to compare objects - When objects (outside of coords) are compared via ===, the comparison always returns falls, even if objects are same. Thus, with a false comparison, all markers get marked as needing update, negating doRebuildAll=false. This fixes false negative on comparison. - Add simple examples page with examples controller for issue angular-ui#1485. - Update model-key spec to include a non-coord comparison on markers Closes angular-ui#1485
|
is it fixed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Not sure if this is related to #1447
When pushing markers to array, even with doRebuildAll=false specified, markers seem to be rebuilt (assuming since they flash). When adding 1000's of markers, this gets cumbersome.
This was working with 2.0.12, but seems to no longer work with 2.2.0. I created a Plunker to compare. You can simply comment out the 2.2.0 scripts and uncomment the 2.0.12 scripts in the HTML to see the difference. I added Animation to markers so it's easier to see. Click "Add Marker" to randomly add a marker and see them re-build.
Plunker example
Love this library, thanks in advance for the help. Happy to add to the example if needed.
The text was updated successfully, but these errors were encountered: