fix(accordion): revert to empty href

- Revert to empty href to avoid user triggered routing problems Fixes #4104
angular-ui · Aug 4, 2015 · b18dc8f · b18dc8f
1 parent 394fcc2
commit b18dc8f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/template/accordion/accordion-group.html b/template/accordion/accordion-group.html
@@ -1,7 +1,7 @@
 <div class="panel panel-default">
   <div class="panel-heading">
     <h4 class="panel-title">
-      <a href="#" tabindex="0" class="accordion-toggle" ng-click="$event.preventDefault(); toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
+      <a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
     </h4>
   </div>
   <div class="panel-collapse collapse" collapse="!isOpen">

diff --git a/template/tabs/tab.html b/template/tabs/tab.html
@@ -1,3 +1,3 @@
 <li ng-class="{active: active, disabled: disabled}">
-  <a href="#" ng-click="$event.preventDefault(); select()" tab-heading-transclude>{{heading}}</a>
+  <a href ng-click="select()" tab-heading-transclude>{{heading}}</a>
 </li>
diff --git a/template/typeahead/typeahead-match.html b/template/typeahead/typeahead-match.html
@@ -1 +1 @@
-<a href="#" ng-click="$event.preventDefault()" tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query"></a>
+<a href tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query"></a>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<a href="#" ng-click="$event.preventDefault()" tabindex="-1" bind-html-unsafe="match.label \| typeaheadHighlight:query"></a>
		<a href tabindex="-1" bind-html-unsafe="match.label \| typeaheadHighlight:query"></a>