Accordion doesn't propagate is-open to parent scope

[laz2]

accordion.js, line 94

scope.$watch('isOpen', function(value) {
    if ( value ) {
        accordionCtrl.closeOthers(scope);
    }
    if ( setIsOpen ) {
        setIsOpen(scope.$parent, value); // <---
    }
});

This code sets isOpen in parent scope, but for 'accordionGroup' directive parent scope is scope of 'accordion' directive. IMHO, just replace scope.$parent with scope.$parent.$parent

[pkozlowski-opensource]

@laz2 http://plnkr.co/ with a reproduce scenario, please...

[bekos]

@laz2 is right! Actually there are cases (our demo page is one of them) that user's scope is 3 $parent up.
I think the only safe way to access the appropriate scope is through accordion.

Will submit PR soon.

[kirkhoff]

@bekos I'm noticing that after this change I'm no longer able to set isOpen to a scoped variable in a parent controller of the accordion. Example: If I want to set your variable, "isopen" to true by default in my controller, $watch won't pick it up anymore. Thoughts?

[bekos]

@kirkhoff This commit was buggy :-( It has been corrected by 9ec2128. Can you try with latest build from master? If not working, you can open a new issue with a plnkr to reproduce.

[kirkhoff]

@bekos too funny. That's exactly what I ended up doing on my end. Thanks for the fast response :)

[cottrelld]

Ran into this on the latest. I have a controller with variables such as isOpen1 isOpen2, etc. One for each accordionGroup.

isopen1={{isopen1}}

   <accordion close-others="false" class="ui-accordion" id="myAcc">
        <accordion-group is-open="$parent.isopen1"  id="category-1">
            <accordion-heading>
                My Heading here <i class="pull-right glyphicon" ng-class="{'glyphicon-chevron-down': isopen1, 'glyphicon-chevron-right': !isopen1}"></i>
            </accordion-heading>

... bunch of controls then

Next Section    

doset is a method on my controller:

    $scope.doset = function() {
        $scope.isopen1=false;
        $scope.isopen2=true;
    }

Changing the variables this way has no effect with the master code. Setting setIsOpen(scope.$parent, value); as suggested above makes the code work and the accordions close/open as expected for me...