Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Consider add trigger property to popover #131

Closed
marcospassos opened this issue Feb 10, 2013 · 6 comments
Closed

Consider add trigger property to popover #131

marcospassos opened this issue Feb 10, 2013 · 6 comments

Comments

@marcospassos
Copy link

In some cases, I use the popover as a tooltip. Would be nice have a trigger property to set the event type, that for now is hardcoded.
@pkozlowski-opensource
Copy link
Member

Yep, definitively should be on the road-map for both tooltip and popovers...

@joshdmiller
Copy link
Contributor

It's in the TODO notes at the top of both.

This is super simple to implement, but we should probably refactor the
tooltip and popover before we add more identical functionality to each.
On Feb 10, 2013 7:43 AM, "Pawel Kozlowski" notifications@github.com wrote:

Yep, definitively should be on the road-map for both tooltip and
popovers...

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/131#issuecomment-13351528..

@pkozlowski-opensource
Copy link
Member

Totally agree, refactor first.

@L42y
Copy link
Contributor

L42y commented Mar 29, 2013

Is the refactoring finished? I saw popover changed a lot and depends on $tooltip right now.

@pkozlowski-opensource
Copy link
Member

@L42y nope, still on the roadmap. A pull request would be awesome :-)

@joshdmiller
Copy link
Contributor

The refactor is finished, though there are still some bugs. The trigger would be part of the provider and a generalized solution for both tooltip and popover with different defaults for each. This is actually a fairly simple change now.

I agree wtih @pkozlowski-opensource - a PR would be awesome. :-) Otherwise, we'll get to it eventually, but we're focused on a few bugs right now.

@L42y L42y mentioned this issue Apr 1, 2013
Closed
joshdmiller pushed a commit that referenced this issue Apr 27, 2013
feat($tooltip): support for custom triggers
417b01f 
The `$tooltip` service now has two ways to customize the default triggers.
The `$tooltipProvider` takes a `trigger` option and the `*-trigger`
attribute can be applied to a single element.

The `$tooltipProvider`'s `trigger` option overwrites the default value
but the attribute will overwrite both.

A few logical default triggers are supported out of the box and have an
associated map to determine which hide trigger to use. `mouseenter` ->
`mouseleave`, `focus` -> `blur`, and `click` -> `click`. If any other
trigger is provided, it will be used to both show and hide the tooltip.

Custom hide triggers are not yet supported as they would require some
code trickery due to the way `$observe` works.

Closes #131
@joshdmiller joshdmiller mentioned this issue Apr 27, 2013
Closed
codedogfish pushed a commit to codedogfish/angular-ui-bootstrap that referenced this issue Sep 15, 2015
@dimirc
Merge pull request angular-ui#131 from angular-ui/fix-singlebinding
df2e931 
Correctly bind single properties to child array
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@joshdmiller @L42y @marcospassos @pkozlowski-opensource