Carousel causes a memory leak.

[joshkurz]

The carousel in its current form causes a memory leak due to how it uses $timeout.

If the carousel's scope is destroyed, then the timeout that moves the carousel forward is still ran even though there is no carousel in the DOM and the Scope has been destroyed.

Here is an example. http://plnkr.co/edit/RyZpy2IvZFM3mMmxQ2kY?p=preview
If you click on the splice button twice it will remove both of the carousels and then if you look in the console, the print statement is still ran even though there is no carousel.

The fix is to cancel the timeout right before the carousel sets a new one and to cancel it also during the $destroy event.
http://plnkr.co/edit/E2cAbH2VocvqbNorjlDv?p=preview

I can create a PR for this if you believe it is a problem.

[bekos]

@joshkurz This is definitely a bug and as such, also a problem :-)
The proposed solution seems right and of course a PR from you is more than welcomed!!!

[joshkurz]

thanks @bekos

Ill get one together and send it in.