This repository has been archived by the owner on May 29, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1636
This adds a .npmignore to reduce the size of a published NPM package (while allowing the built files in ./dist to be published), as well as setting npm's prepublish script to run grunt build, so the files don't have to be built after pulling in from npm.
Alternatively, we could have this be an install script (so once they pull the source from NPM, it compiles locally), but as described on the NPM site that is generally an antipattern, and where possible the ready-to-go concatenated scripts should be published instead.
With this NPMignore setting, the only files that should be present once published to NPM should be the compiles js in dist, the npmignore, the changelog, the readme, license, and package.json.