Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Collapse usage inside modal: section "pops" when not collapsed #4414

Closed
levin81 opened this issue Sep 14, 2015 · 5 comments
Closed

Collapse usage inside modal: section "pops" when not collapsed #4414

levin81 opened this issue Sep 14, 2015 · 5 comments
Labels
component: modal type: ngAnimate
Milestone
1.0.1

Comments

@levin81
Copy link

levin81 commented Sep 14, 2015

http://plnkr.co/edit/x7FIiKirhANONuAwgKvH?p=preview

Just added to the unordered-list element a 'collapse="false"' (so everything should be business as usual), but when the modal is loaded it first displays the rest of the elements and then the element with the collapse directive pops into view.
@wesleycho wesleycho added this to the 0.14.x milestone Sep 14, 2015
@wesleycho
Copy link
Contributor

I think this might be a duplicate of an existing issue - not quite sure what is causing this bug, it needs some investigation.

@wesleycho wesleycho modified the milestones: 0.14.x, 1.0.0 Oct 23, 2015
@wesleycho
Copy link
Contributor

Just noting, I suspect this could be a ngAnimate regression in Angular.

@icfantv
Copy link
Contributor

icfantv commented Oct 28, 2015

Given the age of this in OSS days we should see if it's reproducible with the latest code versions. When I was going through the backlog this morning I was able to close several animation issues just by doing this.

@wesleycho
Copy link
Contributor

This is still an issue in master, as can be seen here.

@wesleycho wesleycho modified the milestones: 1.0.0, 1.0.1 Jan 8, 2016
This was referenced Jan 11, 2016
Closed
Closed
@icfantv
Copy link
Contributor

icfantv commented Jan 11, 2016

Closing in favor of #5192. Also see PR #5199.

@icfantv icfantv closed this as completed Jan 11, 2016
wesleycho pushed a commit that referenced this issue Jan 15, 2016
@bogdanalexe90 @wesleycho
fix(collapse): avoid initial animation when expanded
57219aa 
- Ensures collapse does not animate expanding when initialized as
  expanded

Closes #5199
Fixes #4414
Fixes #5192
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: modal type: ngAnimate
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
3 participants
@icfantv @wesleycho @levin81