-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Default carousel template is not accessible #4478
Comments
This is way too old of a version for us to support - for reference, that version was released 1 year ago (minus one day). |
@wesleycho the way I understood what @eduncan26 was saying is that we still got this issue... |
You have the same accessibility issues with the latest release -- the only thing that really helps is that you support custom templates in 0.13. The default template between 0.11 and 0.13 is essentially the same. I understand not wanting to support 0.11, but the default template should be more accessible than it is currently. For my project I have updated to 0.13 because I need to make the carousel accessible. I can get you a PR today for improved accessibility just by changing the markup. The accessibility team I work with has also suggested focus path improvements as well (refocus the slide on slide change). |
Do you happen to know what changes are necessary for accessibility? It would help speed things up if you're willing to file a PR with the fixes necessary - otherwise we can try figuring it out. |
I'll get you a PR shortly |
Awesome @eduncan26 ! This is the open source spirit! |
- Improves accessibility of carousel Closes angular-ui#4478 Closes angular-ui#4479
Here is a plunker of a failing scenario: http://plnkr.co/edit/pouPdsf3ugooUiyHMPTV?p=preview
The default template is not accessible via keyboard navigation nor with screen reader assistance. While tabbing through the document you should be able to get keyboard focus on the carousel controls. While using assistive technology, you should also be able to tab-stop on the carousel controls. Neither of these are working as-is.
I understand that newer versions allow for custom templates but there are very minimal changes to the default template that would allow all versions to be much more accessible.
The text was updated successfully, but these errors were encountered: