Pressing ESC with a dropdown inside a modal dialog

[asfordmatt]

Bug description:

If I have a dropdown widget inside a modal dialog and the dropdown is open, and then I press Escape, it closes the dialog. I would expect pressing Escape to close the dropdown only and not the dialog as well. If the dropdown is closed, pressing Escape would then close the dialog. Could this be addressed by calling evt.stopPropagation() when handling the escape key in dropdown.js?

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/T2gDRud9wpg8XpbLu3Yc?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.3

UIBS: 1.3.1

Bootstrap: 3.3.6

[deeg]

Since esc closes typeahead and dropdowns I would argue both should behave the same way. If making a PR to fix for dropdown, please make sure typeahead works the same way.

[wesleycho]

Marking as a breaking change, but the side-effects should be minimal, if it affects anyone at all.

Looks like we do close a dropdown on escape, so it makes sense to stop the event propagation.

[asfordmatt]

@deeg good call, I agree typeahead should work the same way - in fact it already works the way I think the dropdown should work. It stops event propagation so that ESC only closes the typeahead dropdown not the dialog as well. I created a plunkr to test it out:
http://plnkr.co/edit/Drvukb7zDOISdEfBXM1C?p=preview