This repository has been archived by the owner on May 29, 2019. It is now read-only.
Editable input (WIP) #775
Comments
|
Closing this for now, wasn't aware that ngModel could take a $parent scope to avoid breaking the filter chain. Will write tests and PR my changes in a day or two. |
mattslocum
pushed a commit
to mattslocum/bootstrap
that referenced
this issue
May 7, 2014
Child scope prevented tooltips on input elements from binding to the correct scope. Tests have been updated accordingly. Fixes angular-ui#775 Fixes angular-ui#2092
mattslocum
pushed a commit
to mattslocum/bootstrap
that referenced
this issue
May 7, 2014
Child scope prevented tooltips on input elements from binding to the correct scope. Tests have been updated accordingly. Fixes angular-ui#775 Fixes angular-ui#2092
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm currently working on an editable input (inline text that turns into a form field when clicked on) but have run into a bind. The code is complete (although, without tests) at hallister/angular-ui-bootstrap@882d088.
The big issue here is that the editable has to have an isolate scope (form validation requires compiling against the scope, and we don't want to be doing that in a controller scope!) and update the model. Doing it this way (=ngModel) breaks the two-way bindings (watchers on primitives, filters etc). So a few questions:
Is there any interest in this (from anyone, but ideally the core developers)?
Would this directive still be considered useful given the caveat above?
Of course, if anyone has a suggestion for the issue above please let me know! I can't PR this now since tests aren't written, I just wanted to feedback before I invest anymore time into it (in my use case, the caveat is fine).
The text was updated successfully, but these errors were encountered: