Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Fix for issue #96. Refresh tooltip after any change in the content. #1373

Closed
wants to merge 1 commit into from

Conversation

ventuc
Copy link

@ventuc ventuc commented Dec 9, 2013

This pull request fixes issue #96.

At every content change checks if the tooltip is open. If so hides it and then shows it gain. This automatically position the tooltip correctly. Uses $q in the hide() function in order to notify the caller when the tooltip has been hidden.

angular-ui#96. Essentially hides the
tooltip and shows it again if it was open.
@bekos
Copy link
Contributor

bekos commented Dec 16, 2013

@ventuc Thanks a lot for your PR, but the problem with your approach was that it is recalculating $position (an expensive operation) on every content change and also i am not so keen of constantly showing/hiding the tooltip from UX perspective. Lastly, I believe it's adding a bit of code complexity, by introducing promises.

So even though your patch hasn't made it in, it helped a lot to come up with the #1415.
Looking forward to your next PR, and if you can help test #1415 that would be awesome :-)

@bekos bekos closed this Dec 16, 2013
@ventuc
Copy link
Author

ventuc commented Dec 16, 2013

Ok, I understand. For what concerns promises, maybe a simple callback function would have been better. Anyway, I will follow your advice, so I will try to contribute to issue #1415 as soon as possible.

Thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants