This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): leaking watchers due to scope re-use #1498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the backdropScope was being re-used and each time it was linked, it would attach more watchers to the scope. Resolves angular-ui#1491
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the backdropScope was being re-used and each time it was
linked, it would attach more watchers to the scope.
Resolves #1491
Note: Due to a bug in pre-1.2 AngularJS (replaced directives with templateUrls lose reference to the node, plunker here), the backdrop's template can't be cached and re-used. Post-Angular 1.2 we should compile the backdrop element only once and re-use it after.