[Pagination] Add first/last link & constant congif options. #173
Conversation
|
After the #159 problems, i believe i got a better idea to sort this out. With this approach, i could make pagination more configurable. Also there is no hiding of elements, so no CSS problems :-) I hope you like it! |
|
@bekos This version looks much better! @petebacondarwin This lgtm but it would be great if you could have a quick look |
| // Add page number links | ||
| for(var i = 0, n = Math.min(maxSize, scope.numPages); i < n; i++) { | ||
| var number = startPage + i; | ||
| var page = { |
There was a problem hiding this comment.
You repeat this var page = { number: .., text: .., active: .., disabled: .. } a lot. Couldn't you create a function makePage(number, text, active, disabled) {} function and use that? It would reduce your lines of code a lot and you'd avoid repeating yourself 👍
|
All looks good, except the one comment I made. Thanks @bekos! This needed a bit of a refactor. |
|
@ajoslin Fixed! Also i fixed the iteration over page numbers. |
|
@bekos this looks far better now! Could you squash all the commits into a single one and rebase it on top of the current master? This would help me a lot in merging this PR. |
* Options for text of first, previous, next & last links. * Option "boundary-links" whether to display "first" & "last" link (default: false) * Option "direction-links" whether to display "previous" & "next" link (default: true) * Added tests!!! * Fix demo to show all possible configuration options
|
@pkozlowski-opensource I think it's OK now. |
(default: false)
(default: true)