fix(modal): should not throw an exception when a modal isn't on the stack

[venuatu]

No description provided.

[chrisirhc]

Looks like a good addition.

[bekos]

@venuatu OK, this seems like a logic change, but I would like to know the case that you try to dismiss an already dismissed modal.

[AidasK]

When this is going to be released? This is a very ugly issue.
For me this happens in watch statement:

$scope.$watch('files.length', function () {
  if (files.length == 0) {
    $scope.$close();
  }
});

[venuatu]

I had some code which was a crud list with a single modal up at a time and it broke on this issue when I upgraded from 0.6 (iirc) to the latest version
When I looked at what was breaking it looked like the original intent was to allow for this behaviour
The code I had was something like:

var modal;

function closeModal() {
    if (modal)
        modal.close();
    modal = undefined;
};

$scope.updateSomething = function (something) {
    closeModal();
    modal = $modal.open(...)
};

$scope.$on('$destroy', closeModal);

[pkozlowski-opensource]

@venuatu thnx for this PR. Could you please rebase on top of the current master and squash commits so there is only one commit in the pull request?

[venuatu]

@pkozlowski-opensource done

[pkozlowski-opensource]

Merged, thnx @venuatu !

[AidasK]

Uhhh, and this is not in the release 11.0 :/

[byeval]

thx~

[johannesjo]

This should be merged asap!

[chaizhenhua]

hi, can this patch fix this error ? or is this error already fixed ?

"Error: openedWindows.get(...) is undefined
$modalStack.close@http://0.0.0.0:9000/bower_components/angular-bootstrap/ui-bootstrap-tpls.js:2006:27
$modalProvider.$get</$modal.open/modalInstance.close@http://0.0.0.0:9000/bower_components/angular-bootstrap/ui-bootstrap-tpls.js:2075:17