This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): date formatting when using angular 1.3 fixes #2659 #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to see this merged. I am pinned to an older version of angular until this gets resolved. |
|
👍 |
|
Could you let us know when this fix will be released? Thanks. |
|
👍 |
|
Is this issue fixed and merged? |
|
it haven't been merged~! hope soon |
|
LGTM, I just tested it using angular 1.3 and all tests pass. I will discuss this with @pkozlowski-opensource at NG-NL and we will move forward. |
|
For reference: #3293 |
|
@DaveWM Thanks a lot. see the working plunkr: http://plnkr.co/edit/0EEK4JpvW7GXqbhAgVwJ?p=preview regrads |
DKnodel
pushed a commit
to DKnodel/bootstrap
that referenced
this pull request
Apr 9, 2015
…-ui#2659 Closes angular-ui#3293 Closes angular-ui#3279 Closes angular-ui#2440 Closes angular-ui#2932 Closes angular-ui#3074 Closes angular-ui#2943 Closes angular-ui#2733 Fixes angular-ui#3047 Fixes angular-ui#2659 Fixes angular-ui#2681
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put a fix in for this, as suggested by @bcronje. I also had to parse the $viewValue to a date in the $render function.