This repository has been archived by the owner on May 29, 2019. It is now read-only.
Update modal.js #2791
Closed
Update modal.js #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add timeout before setting scope.animate = false; to make sure the modal backdrop's scope gets applied.
|
@doranen I'm not sure I full understand the issue you are trying to fix. Things would be much easier if you would add tests that demonstrate the issue you are fixing here. Tests are mandatory before merging anyway so please add a test so we can discuss / merge this one. |
|
This is likely invalid now with the work that has been done in #2724. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add timeout before setting scope.animate = false; to make sure the modal backdrop's scope gets applied.