This repository has been archived by the owner on May 29, 2019. It is now read-only.
Refactor tooltip classes #3510
Closed
Refactor tooltip classes #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tooltip-class support to tooltip-template - Remove observer for tooltip-class, it’s evaluated once on tooltip preparation instead - Remove interpolation on class attribute Interpolation on the class attribute can have undesirable mangling effects when use with a directive that has `replace: true`. It also doesn’t work properly with ngAnimate. Relates to angular-ui#3126
chrisirhc
force-pushed
the
feature/fix-placement-classes
branch
from
c5fd16d to
f7e4995
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparation instead
Interpolation on the class attribute can have undesirable mangling
effects when use with a directive that has
replace: true. It alsodoesn’t work properly with ngAnimate.
Relates to #3126
Merge after #3509