This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(timepicker): always pad minutes #3533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this change. However, this creates an issue where I can't type "10:50" as the input now. Two digit minutes can't be typed into the display. I think instead, the fix/feature should be something along: if (keyboardChange !== 'm') {
$scope.minutes = pad(minutes);
} |
- Always pad minutes as a UX improvement - Make suggested fix as per CR
wesleycho
force-pushed
the
feat/pad-minutes
branch
from
d4cf77d
to
c598170
Compare
|
Good catch - made change as suggested, works for both use cases. Updated Plunker with new build. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plunker
Fixes #1598
Related to #2639