This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(alert): move dismiss-on-timeout to an attribute #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - just a note, the dropdown has a similar problem with keyboard-nav being separate. |
|
I am still in the A, will reach D soon. |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
Closes angular-ui#4405 BREAKING CHANGE: Alert's dismiss-on-timeout is now an attribute inside uib-alert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It never made sense as a separate directive, it only adds overhead to this little component and it is not needed at all. Also, it would need prefixing and that would make it uglier.
BREAKING CHANGE: Alert's dismiss-on-timeout is now an attribute inside
uib-alert.