This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add deprecation notices #5415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wesleycho
commented
Feb 5, 2016
wesleycho
commented
- Add deprecation notices for datepicker & popup
| datepickerPopupConfig.altInputFormats; | ||
| } else { | ||
| if (datepickerPopupAttributeWarning) { | ||
| $log.warn('uib-datepicker-popup attributes deprecated and will be removed in UI Bootstrap 1.3, use datepicker-options attribute instead'); |
There was a problem hiding this comment.
This sentence needs a word. Perhaps attributes are deprecated and ....
There was a problem hiding this comment.
Whoops - will fix that quick before merging.
|
this LGTM, bugs will arose for sure but we will fix them before 1.3 Also, this needs a massive doc update (to reflect how to use the directive right now with some deprecation notice). I will create a doc PR once we merge this. |
|
Ah, also the demo needs to be updated. That can be done in another PR or here. |
wesleycho
force-pushed
the
feat/datepicker-deprecation
branch
from
5a2809f to
94bec7a
Compare
|
Let's get this in - I actually wanted to do more in this PR, but this alone turned out to be a lot of work. |
- Add deprecation notices for datepicker & popup
wesleycho
force-pushed
the
feat/datepicker-deprecation
branch
from
94bec7a to
a97b364
Compare
|
Merge it. I will do the rest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.