This repository has been archived by the owner on May 29, 2019. It is now read-only.
refactor(tab): change to use centralized active state #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to store active index on tabset controller - Set index on tab by tab basis BREAKING CHANGE: The tab API is changed - please refer to the documentation on new usage of tabs. Note that if you are using custom templates, the templates will need to be changed slightly.
wesleycho
force-pushed
the
refactor/tab-api
branch
from
42ab60b to
c132dcf
Compare
| @@ -37,6 +42,9 @@ AngularJS version of the tabs directive. | |||
| * `heading` - | |||
| Heading text. | |||
|
|
|||
| * `index` - | |||
| Tab index | |||
|
Apart from those two points, works for me. |
This was referenced Feb 16, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The tab API is changed - please refer to the
documentation on new usage of tabs
This implements the hardest part of #4836.