This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): focus defaults to the modal itself, not the first element #6295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently bumped version from 2.1.4 to 2.2.0.
In the updated version, modals set default focus to the firstFocusableElement. This seems like unwanted default behavior (for example, input elements may have additional focus behavior that I'd like not to trigger by default).
Also, modals already had a viable and acceptable default state -- focus would be applied to the modal itself when
autofocus
wasn't explicitly set on any element.This change is a quick example of the minimal changes required to revert to simpler, less opinionated, default behavior.