Skip to content

Commit

Permalink
fix(clearThisRowInvisible) not using parameter reason
Browse files Browse the repository at this point in the history
Not sure if intended but clearThisRowInvisible is not using the parameter "reason" when deleting the "invisible reason" but it always deletes the hardcoded parameter "user". 
This shouldn't change any other behavior since ng-grid internal functions call this function only with the parameter "user" but it will fix any error if someone was directly using this function with a custom invisible reason
  • Loading branch information
valepu committed May 6, 2015
1 parent efd3798 commit b955a2d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/js/core/factories/GridRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ angular.module('ui.grid')
*/
GridRow.prototype.clearThisRowInvisible = function ( reason, fromRowsProcessor ) {
if (typeof(this.invisibleReason) !== 'undefined' ) {
delete this.invisibleReason.user;
delete this.invisibleReason[reason];
}
this.evaluateRowVisibility( fromRowsProcessor );
};
Expand Down Expand Up @@ -216,4 +216,4 @@ angular.module('ui.grid')
return GridRow;
}]);

})();
})();

0 comments on commit b955a2d

Please sign in to comment.