Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE8 throwing error due to javascript forEach #394

Closed
sdesmond opened this issue May 6, 2013 · 2 comments
Closed

IE8 throwing error due to javascript forEach #394

sdesmond opened this issue May 6, 2013 · 2 comments
Assignees
@c0bra
Labels
type: bug
Milestone
2.0.6

Comments

@sdesmond
Copy link

sdesmond commented May 6, 2013

Getting TypeError: Object doesn't support this property or method at line 418 ng-grid-2.0.5.debug.js.

This line uses the javascript forEach instead of the angular forEach (which seems to be used everywhere else in the file). This is causing an error in IE8. Changing to Angular's version corrects the problem.
@c0bra
Copy link
Contributor

c0bra commented May 6, 2013

My fault. I will make the switch to angular.forEach() and add an appropriate test. Thanks for catching this.

@ghost ghost assigned c0bra May 6, 2013
c0bra added a commit that referenced this issue May 6, 2013
@c0bra
Fixes #394, Array.forEach() assumed to exist
e4b08a7 
IE8 doesn't support the Array prototype's forEach() method, and I used it
in grid.initTemplates(). I've fixed this to use angular.forEach() instead
and added a test to catch calls in initTemplates() to
Array.prototype.forEach()
@c0bra
Copy link
Contributor

c0bra commented May 8, 2013

Closed in 2.0.6 branch

@c0bra c0bra closed this as completed May 8, 2013
@c0bra c0bra mentioned this issue May 13, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c0bra c0bra

Labels
type: bug
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
2 participants
@c0bra @sdesmond