fix(clearThisRowInvisible) not using parameter reason #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if intended but clearThisRowInvisible is not using the parameter "reason" when deleting the "invisible reason" but it always deletes the hardcoded parameter "user". This shouldn't change any other behavior since ng-grid internal functions call this function only with the parameter "user" but it will fix any error if someone was directly using this function with a custom invisible reason
PaulL1
added a commit
that referenced
this pull request
May 19, 2015
fix(clearThisRowInvisible) not using parameter reason
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if intended but clearThisRowInvisible is not using the parameter "reason" when deleting the "invisible reason" but it always deletes the hardcoded parameter "user".
This shouldn't change any other behavior since ui-grid internal functions call this function only with the parameter "user" but it will fix any unexpected behavior when using this function with a custom invisible reason
Haven't put a check if the value exists since "delete" fails silently in that case