Fix for issue 3528. When exiting the grid the focusedCells list was n… #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot getting cleared which meant that if focus was returned the book keeping around cell focus was not done.
|
This looks good to me, but I'd want @swalters to cast an eye over it before merging - just in case it messes with something he knows about and I don't. Thanks for the contribution. |
swalters
added a commit
that referenced
this pull request
Jun 12, 2015
Fix for issue 3528. When exiting the grid the focusedCells list was n…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 3528. The idea is the focusedCells list wasn't getting cleared when navigating outside the grid and so the book keeping wasn't being done when focus was returned. There's a side effect here that I'm not sure about... With this fix tabbing out of the grid causes the focus highlight in the grid to disappear. I think it's probably valid but up to you! I included a unit test for the fix.