fix(cellNav): Error when field defined with number #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cell nav was throwing an error when you had a field defined like `'1.b'` Resolved by using the `getQualifiedColField` method on the gridRow. Closes #4258
|
the change looks good. One question I have is why is this code in cellNav? it doesn't look like a cellNav specific logic. Should it be moved to core? |
|
Sure? I suppose. I put it here because that's where it was originally defined before I made it an angular module. I can move it to core in another PR. |
JLLeitschuh
added a commit
that referenced
this pull request
Aug 25, 2015
fix(cellNav): Error when field defined with number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cell nav was throwing an error when you had a field defined like
'1.b'Resolved by using the
getQualifiedColFieldmethod on the gridRow.Closes #4258