fix(uiGrid): Fix race condition in data watcher #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modifyRows is now passed the most recent data that the dataWatchFunction has seen Fixes race condition when retrieving templates via URL. $q.all promise in dataWatchFunction would resolve and pass in outdated grid data from the original dataWatchFunction call. Fixes #4532
|
#2053 is a similar issue that @c0bra fixed a year ago (2b25f24). It seems that the fix then was to prevent the promises from resolving out of order. This fix was reverted by the changes made in #4428. This PR doesn't fix the promises resolving out of order but instead prevents the wrong data being set if they do. |
swalters
added a commit
that referenced
this pull request
Dec 29, 2015
fix(uiGrid): Fix race condition in data watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a guard to reduce some unnecessary calls to
buildColumnsandpreCompileCellTemplateseach time data is changed.As a result, the
$q.allpromise indataWatchFunctioncould resolve before promises created in previous calls. This is because an empty array of promises can be passed to$q.allthe method now. This unearthed an issue wheremodifyRowscould be passed outdated data from previousdataWatchFunctioncalls, rather than the most recent call.Fixes #4532, issue introduced by #4428.