fix(uiGridHeader) stop preserving explicit header heights #6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are rebuilt. fixes angular-ui#3705
|
I went back and looked at the issues and linked plunkers I addressed with this original change in 2015 and I could not reproduce them. I think the underlying issue was that styles were not being recalculated as often as they should have. I suspect the changes in 553d72b fixed that. If anyone can reproduce those earlier issues I will certainly take another look. |
mportuga
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop preserving explicit header heights when styles are rebuilt. The buildStyles function fails to expand header height when it was previously set explicitly, and if explicit definition is needed it will be reset to the same value below.
fixes #3705