Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-animate support for ui-view #80

Closed
wants to merge 1 commit into from
Closed

ng-animate support for ui-view #80

wants to merge 1 commit into from

Conversation

rynz
Copy link

@rynz rynz commented Apr 11, 2013

Transitions views in/out with AngularJS v1.1.4 ng-animate directive. Mimics the implementation of ng-view directive.

@jeme
Copy link
Contributor

jeme commented Apr 11, 2013

@ksperling is actually working on this at https://github.com/angular-ui/ui-router/tree/issue-22 And I think we should keep it in a Branch until ng-animiate works properly... (There is some issues rising from things like repeat inside views etc.)

Right now there is quite a few things about animate: angular/angular.js#2304, angular/angular.js#2332, angular/angular.js#2346, angular/angular.js#2351 etc...

I think we should wait with supporting this in the main branch until it is stable, I don't know if we should make a more clearly named branch that targets their head or something...

@rynz
Copy link
Author

rynz commented Apr 11, 2013

Okay sounds good, yeah maybe if you could make a branch to target edge cases.

@rynz rynz closed this Apr 11, 2013
@nprbst
Copy link

nprbst commented Jun 26, 2013

It looks like @ksperling has not progressed for 2 months on this. As of AngularJS 1.1.5 (1 month ago), ngAnimate is pretty stable and usable. Any chance this work will get completed in the near future? Sure would like to use it in my projects...

@laurelnaiad
Copy link

Thats pretty harsh man. @ksperling is the reason you have this to worry about. I hope you didn't mean it how it sounded.

@nateabele
Copy link
Contributor

@nathanprobst Oh, you must be new to Open Source.

@ksperling
Copy link
Contributor

@nathanprobst this was implemented about two months ago: 9882b63 which is why the corresponding issue (#22) and this PR were closed.

@nprbst
Copy link

nprbst commented Jul 8, 2013

@ksperling, I'm so sorry if I sounded harsh! Guess I was having a bad day...but that's not an excuse.

I really appreciate the work you have done on ui-router and sincerely hope it get's adopted by the main AngularJS project soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants