Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Disabling ui-select applies .ng-hide to input box #1302

Closed
punmechanic opened this issue Nov 11, 2015 · 8 comments
Closed

Disabling ui-select applies .ng-hide to input box #1302

punmechanic opened this issue Nov 11, 2015 · 8 comments

Comments

@punmechanic
Copy link

Is there any reason for this? I would have expected the input box to remain visible but just be grayed out.

@punmechanic
Copy link
Author

In order to hack-fix remedy this, I've removed the ng-hide="$select.disabled" directive from the bootstrap/select-multiple.tpl.html template on my local copy. Is the only 'real' work-around to supply a custom template via themes?

@aliig
Copy link

aliig commented Nov 15, 2015

+1 any css workaround?

@wesleycho
Copy link
Contributor

Having the input be displayed when disabled actually results in text display bugs involving CSS - is there a compelling reason why it must be shown?

@punmechanic
Copy link
Author

Because otherwise the input box disappears completely and thus looks very strange - especially to the user. We've had questions about this from our end users, which is why I removed it

I'll try and throw together a plunkr tomorrow when I am back in the office.

Further, at least with the "fix" I've posted above, we've not noticed any CSS bugs on any of the browsers we cover (IE11 - IE9, Chrome 48) with the bootstrap theme (maybe it is causing issues with other themes)

@lukasolson
Copy link

lukasolson commented May 31, 2016

You can see this on the example page by clicking on "Disable ui-select" and looking at the input under "Deselect callback with single property binding".

image

@lukasolson
Copy link

lukasolson commented May 31, 2016

(Specifically, this is very apparent when you're using multiple and disabled simultaneously and the selection is empty.)

@lukasolson
Copy link

@wesleycho Any updates on this? I think we can at least drop the needs info/plunkr labels at this point. I'm happy to help in any way I can.

@user378230
Copy link
Contributor

Closing as resolved by #1717

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants