This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Fix numerous issues with select enabled #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375 Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)
Previously when searchEnabled was set to false, the placeholder would also be hidden on the selectize theme. This fix sets the search input to disabled rather then hidden when the searchEnabled attribute is set to false. Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691
Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes angular-ui#1658
user378230
force-pushed
the
fix-select-enabled
branch
from
8c81552 to
4184fa7
Compare
|
Hey @user378230, Do you have an NPM account? I'd like to add you as an owner of the npm project so that you can publish new versions. If you don't have an account but would be interested in helping to publish new packages to NPM, please sign up and send me your NPM username: |
|
@aaronroberson I don't need to since 12c37bc ( |
|
It doesn't seem to be working? |
|
Hi guys, About |
|
I don't have/use a Mac, feel free to submit a fix. 😃 |
This was referenced Aug 19, 2016
kboga
pushed a commit
to kboga/ui-select
that referenced
this pull request
Nov 29, 2016
* fix(searchEnabled): maintain keyboard nagivation Fix issue where keyboard navigation was disabled when searchEnabled was set to false. Caused by hiding the input box which prevent key events from propagating to the directive. Resolved hiding the input offscreen when searchEnabled is false. Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375 Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all) * fix(selectize): show placeholder when search disabled Previously when searchEnabled was set to false, the placeholder would also be hidden on the selectize theme. This fix sets the search input to disabled rather then hidden when the searchEnabled attribute is set to false. Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691 * fix(searchEnabled): Prevent searching when disabled Previously, even when search-enabled was set to false, users could still type in text and filter the list. This made disabling the search feature pointless. This fix prevents text entry to the search input and thus disables filtering. Fixes angular-ui#1658
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(searchEnabled): maintain keyboard nagivation
fix(selectize): show placeholder when search disabled
fix(searchEnabled): Prevent searching when disabled